Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are the upstream of Vectorscan(https://github.com/VectorCamp/vectorscan) and we would like to integrate it into rebar,
we used the vectorscan crate(https://docs.rs/vectorscan-async/latest/vectorscan/index.html)
instead of the original hyperscan crate,
we would appreciate your feedback.
it uses the spack-rs to build vectorscan but I can build it only with sudo for now.
(I fixed it,if the first build fails,there is a spack cache and on the next builds it wrongfully cant find vectorscan)
We added vectorscan with the same counts to every benchmark as hyperscan and
there are only 2 benchmarks that i get different results.
imported/leipzig/bounded-strings-ending-z,count-spans,vectorscan,5.4.11 2024-05-22,failed to run command for 'vectorscan' //*** buffer overflow detected ***: terminated
Error: output did not match what was expected
imported/regex-redux/regex-redux,regex-redux,vectorscan,5.4.11 2024-05-22,failed to run command for 'vectorscan'
This is probably due to the reason that the vectorscan crate doesnt return the start and the end of the match but only the match itself (the vectorscan crate might need some changes to implement this)
Any feedback would be greatly appreciated.