Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vectorscan add to rebar #17

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

gtsoul-tech
Copy link

@gtsoul-tech gtsoul-tech commented Jul 1, 2024

We are the upstream of Vectorscan(https://github.com/VectorCamp/vectorscan) and we would like to integrate it into rebar,
we used the vectorscan crate(https://docs.rs/vectorscan-async/latest/vectorscan/index.html)
instead of the original hyperscan crate,
we would appreciate your feedback.

it uses the spack-rs to build vectorscan but I can build it only with sudo for now.
(I fixed it,if the first build fails,there is a spack cache and on the next builds it wrongfully cant find vectorscan)

We added vectorscan with the same counts to every benchmark as hyperscan and
there are only 2 benchmarks that i get different results.

imported/leipzig/bounded-strings-ending-z,count-spans,vectorscan,5.4.11 2024-05-22,failed to run command for 'vectorscan' //*** buffer overflow detected ***: terminated

Error: output did not match what was expected
imported/regex-redux/regex-redux,regex-redux,vectorscan,5.4.11 2024-05-22,failed to run command for 'vectorscan'
This is probably due to the reason that the vectorscan crate doesnt return the start and the end of the match but only the match itself (the vectorscan crate might need some changes to implement this)

Any feedback would be greatly appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant